Skip to content

Add rust-mingw component for *-windows-gnullvm hosts #147536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 22, 2025
Merged

Add rust-mingw component for *-windows-gnullvm hosts #147536

merged 1 commit into from
Nov 22, 2025
+65 −11

Conversation

@mati865
Copy link
Member

@mati865 mati865 commented Oct 9, 2025 •
edited
Loading

Cc #146634

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 9, 2025
@mati865
Copy link
Member Author

mati865 commented Oct 9, 2025

Tested locally on Windows but a shareable build would be useful.
@bors try jobs=dist-x86_64-linux,dist-x86_64-windows-gnullvm

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot added a commit that referenced this pull request Oct 9, 2025
@rust-bors
Auto merge of #147536 - mati865:gnullvm-self-contained, r=<try>
fa81451 
Windows-gnullvm self-contained

try-job: dist-x86_64-linux
try-job: dist-x86_64-windows-gnullvm
@mati865 mati865 mentioned this pull request Oct 9, 2025
Open
@rust-log-analyzer

This comment was marked as resolved.

Sign in to view
@rust-log-analyzer

This comment was marked as resolved.

Sign in to view
@rust-bors

This comment was marked as resolved.

Sign in to view
@mati865
Copy link
Member Author

mati865 commented Oct 9, 2025

@bors try jobs=dist-x86_64-linux,dist-x86_64-windows-gnullvm

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot added a commit that referenced this pull request Oct 9, 2025
@rust-bors
Auto merge of #147536 - mati865:gnullvm-self-contained, r=<try>
87a3415 
Windows-gnullvm self-contained

try-job: dist-x86_64-linux
try-job: dist-x86_64-windows-gnullvm
@rust-bors
Copy link

rust-bors bot commented Oct 9, 2025

☀️ Try build successful (CI)
Build commit: 87a3415 (87a3415f29207b7d5add0b9bd83328ee459e7843, parent: 0b278a539440be291466ea463a9b6310eaf4d7bb)

mati865
mati865 commented Oct 9, 2025
View reviewed changes
@petrochenkov petrochenkov self-assigned this Oct 10, 2025
@mati865
Copy link
Member Author

mati865 commented Oct 28, 2025

Seems to work nicely, even with -Zbuild-std without having Clang in PATH.
What's left here is a cleanup and reconsideration of what would be the best way to move this forward.

@estebank
Copy link
Contributor

estebank commented Nov 4, 2025

@mati865 are there any blockers we could help you with?

estebank
estebank reviewed Nov 4, 2025
View reviewed changes
@mati865
Copy link
Member Author

mati865 commented Nov 5, 2025

@estebank I had a few ideas how to refactor it, but none of them turned out satisfying. I'm going to take another stab at it this week.

@mati865 mati865 force-pushed the gnullvm-self-contained branch from f3f33b7 to 9d27d77 Compare November 10, 2025 20:02
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@mati865 mati865 force-pushed the gnullvm-self-contained branch from 9d27d77 to 9f92112 Compare November 11, 2025 12:45
@bors

This comment was marked as resolved.

Sign in to view
@mati865 mati865 force-pushed the gnullvm-self-contained branch 2 times, most recently from 48d04c8 to 2b5ac0b Compare November 12, 2025 14:54
@mati865
Copy link
Member Author

mati865 commented Nov 12, 2025

@bors try jobs=dist-x86_64-linux,dist-x86_64-windows-gnullvm

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot added a commit that referenced this pull request Nov 12, 2025
@rust-bors
Auto merge of #147536 - mati865:gnullvm-self-contained, r=<try>
da8dd69 
Windows-gnullvm self-contained

try-job: dist-x86_64-linux
try-job: dist-x86_64-windows-gnullvm
@rust-bors
Copy link

rust-bors bot commented Nov 12, 2025

☀️ Try build successful (CI)
Build commit: da8dd69 (da8dd699e467041c9cfdc421e44ac8758d9288e2, parent: 2fcbda6c1a70606bdb09857e01d01fc6229da712)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 21, 2025
@mati865 mati865 changed the title Windows-gnullvm self-contained Add rust-mingw component for *-windows-gnullvm hosts Nov 21, 2025
@petrochenkov
Copy link
Contributor

petrochenkov commented Nov 21, 2025

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 21, 2025

📌 Commit 3ad8250 has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 21, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 22, 2025
@Zalathar
Rollup merge of rust-lang#147536 - mati865:gnullvm-self-contained, r=…
0a5c1ba 
…petrochenkov

Add `rust-mingw` component for `*-windows-gnullvm` hosts

Cc rust-lang#146634
@Zalathar Zalathar mentioned this pull request Nov 22, 2025
Closed
@mati865 mati865 mentioned this pull request Nov 22, 2025
Open
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 22, 2025
@matthiaskrgr
Rollup merge of rust-lang#147536 - mati865:gnullvm-self-contained, r=…
a20f4d5 
…petrochenkov

Add `rust-mingw` component for `*-windows-gnullvm` hosts

Cc rust-lang#146634
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 22, 2025
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 22, 2025
@matthiaskrgr
Rollup merge of rust-lang#147536 - mati865:gnullvm-self-contained, r=…
421ed84 
…petrochenkov

Add `rust-mingw` component for `*-windows-gnullvm` hosts

Cc rust-lang#146634
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 22, 2025
Closed
bors added a commit that referenced this pull request Nov 22, 2025
@bors
Auto merge of #149216 - matthiaskrgr:rollup-xtf90h6, r=matthiaskrgr
c3c8d5c 
Rollup of 8 pull requests

Successful merges:

 - #147536 (Add `rust-mingw` component for `*-windows-gnullvm` hosts)
 - #148407 (Warn against calls which mutate an interior mutable `const`-item)
 - #149168 (Fix ICE when collecting opaques from trait method declarations)
 - #149170 (automate gpu offloading - part 1)
 - #149180 (Couple of refactors to SharedEmitter)
 - #149185 (Handle cycles when checking impl candidates for `doc(hidden)`)
 - #149194 (Move safe computation out of unsafe block)
 - #149204 (Fix typo in HashMap performance comment)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Nov 22, 2025
@bors
Auto merge of #147536 - mati865:gnullvm-self-contained, r=petrochenkov
94a91dc 
Add `rust-mingw` component for `*-windows-gnullvm` hosts

Cc #146634
@bors
Copy link
Collaborator

bors commented Nov 22, 2025

⌛ Testing commit 3ad8250 with merge 94a91dc...

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 22, 2025
@matthiaskrgr
Rollup merge of rust-lang#147536 - mati865:gnullvm-self-contained, r=…
9b368e3 
…petrochenkov

Add `rust-mingw` component for `*-windows-gnullvm` hosts

Cc rust-lang#146634
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 22, 2025
Closed
@matthiaskrgr
Copy link
Member

matthiaskrgr commented Nov 22, 2025

@bors retry yield rollup

bors added a commit that referenced this pull request Nov 22, 2025
@bors
Auto merge of #149217 - matthiaskrgr:rollup-eghiwzr, r=matthiaskrgr
8cb8621 
Rollup of 7 pull requests

Successful merges:

 - #147536 (Add `rust-mingw` component for `*-windows-gnullvm` hosts)
 - #148407 (Warn against calls which mutate an interior mutable `const`-item)
 - #149168 (Fix ICE when collecting opaques from trait method declarations)
 - #149170 (automate gpu offloading - part 1)
 - #149185 (Handle cycles when checking impl candidates for `doc(hidden)`)
 - #149194 (Move safe computation out of unsafe block)
 - #149204 (Fix typo in HashMap performance comment)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr
Copy link
Member

matthiaskrgr commented Nov 22, 2025

@bors rollup=iffy

@bors
Copy link
Collaborator

bors commented Nov 22, 2025

⌛ Testing commit 3ad8250 with merge 4b1b6dd...

@bors
Copy link
Collaborator

bors commented Nov 22, 2025

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing 4b1b6dd to main...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 22, 2025
@bors bors merged commit 4b1b6dd into rust-lang:main Nov 22, 2025
12 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Nov 22, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 22, 2025

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 1dd43f2 (parent) -> 4b1b6dd (this PR)

Test differences

No test diffs found

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 4b1b6dde0c15243857165672a1c616a4523ef32a --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. aarch64-apple: 7170.7s -> 8365.5s (+16.7%)
  2. dist-arm-linux-musl: 5715.4s -> 6654.6s (+16.4%)
  3. pr-check-1: 1676.4s -> 1945.5s (+16.1%)
  4. x86_64-gnu-tools: 3279.8s -> 3789.7s (+15.5%)
  5. dist-x86_64-illumos: 6099.5s -> 6959.8s (+14.1%)
  6. x86_64-gnu-llvm-21-1: 3152.4s -> 3590.5s (+13.9%)
  7. x86_64-rust-for-linux: 2605.0s -> 2958.1s (+13.6%)
  8. i686-gnu-2: 5411.4s -> 6139.7s (+13.5%)
  9. i686-gnu-nopt-1: 7293.1s -> 8269.6s (+13.4%)
  10. aarch64-gnu-llvm-20-2: 2257.0s -> 2542.4s (+12.6%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@mati865 mati865 mentioned this pull request Nov 22, 2025
Open
@rust-timer
Copy link
Collaborator

rust-timer commented Nov 22, 2025

Finished benchmarking commit (4b1b6dd): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -1.3% [-1.3%, -1.3%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (secondary 2.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.2% [2.2%, 2.2%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Cycles

Results (secondary -1.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -1.9% [-2.2%, -1.6%] 2
All ❌✅ (primary) - - 0

Binary size

Results (primary -0.1%, secondary -0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.1% [-0.1%, -0.0%] 51
Improvements ✅
(secondary)		 -0.1% [-0.1%, -0.0%] 23
All ❌✅ (primary) -0.1% [-0.1%, -0.0%] 51

Bootstrap: 469.271s -> 474.164s (1.04%)
Artifact size: 386.21 MiB -> 386.17 MiB (-0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@estebank estebank estebank left review comments

@petrochenkov petrochenkov petrochenkov left review comments

@bjorn3 bjorn3 bjorn3 left review comments

Assignees

@petrochenkov petrochenkov

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

9 participants

@mati865 @rust-log-analyzer @estebank @bors @rustbot @petrochenkov @matthiaskrgr @rust-timer @bjorn3